Conversation
praiskup
force-pushed
the
releasing-logging
branch
2 times, most recently
from
755a849 to
1f6412f
Compare
Sometimes workers get stuck in RELEASING state forever (until server restart, when all the RELEASING resources are removed). See the Copr issue #2115 for more info [1]. Some related output in hook.log exists, but because the affected resources usually get into RELEASING state times during their lifetimes, it's not easy to tell if (a) the failed ReleaseWorker run for the affected resource actually failed, or (b) if it started, but the cmd_release command (Popen) failed, or (c) ReleaseWorker only failed to store the release status to DB. With this commit, we should have an evidence next time and see what is the problem to be fixed. Relates: https://pagure.io/copr/copr/issue/2115
praiskup
force-pushed
the
releasing-logging
branch
from
1f6412f to
ad9c2ed
Compare
Exceptions raised in Worker threads are totally unexpected, but they probably occasionally happen, see Copr issue #2115. We don't want to terminate the whole resalloc-server process for them for sure (that would cause too much harm) but we should at least log them to main.log appropriately for further analysis. This is per my best judgement, as long as Python interpreter actually successfully starts the Thread, there must be some exception causing that the ReleaseWorker isn't able to store the "RState.UP" into the database. See how simple the related code is (checkout 297f59e, and check resallocserver/manager.py#L207-L209). Relates: https://pagure.io/copr/copr/issue/2115
praiskup
force-pushed
the
releasing-logging
branch
from
ad9c2ed to
956f7be
Compare
praiskup
changed the title
Collaborator
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.