Skip to content

Issue#90 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2018
Merged

Issue#90 #129

merged 3 commits into from
Jul 31, 2018

Conversation

@molex
Copy link
Contributor

@molex molex commented May 11, 2018

Thank you for your contribution. Please provide the details requested below.

ISSUE NUMBER 90

Link to issue

SHORT DESCRIPTION

Many fixes to allow the app to run.

TESTING

Please provide the necessary steps to test the solution.

molex added 2 commits May 11, 2018 15:37
@molex
resolved multiple compile issues. Project now compiles and runs with no
3a6b573 
issues. Not 100% sure if it still matches the original intent, but
it should now be useable.
@molex
Fixed several import issues. Resolved a number of syntax errors and
6c4c0d4 
Pep8 errors. I also fixed the class initialization. I commented out
some code for running the app. There was a mash-up of 2 implementations
I chose one and went with it.
@pep8speaks
Copy link

pep8speaks commented May 11, 2018 •
edited
Loading

Hello @molex! Thanks for updating the PR.

[Line 11:54](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L11): W291 trailing whitespace
[Line 16:27](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L16): W291 trailing whitespace
[Line 17:76](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L17): W291 trailing whitespace
[Line 19:63](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L19): W291 trailing whitespace
[Line 35:43](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L35): W291 trailing whitespace
[Line 37:66](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L37): W291 trailing whitespace
[Line 85:71](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L85): E127 continuation line over-indented for visual indent
[Line 199:9](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L199): E303 too many blank lines (2)
[Line 337:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L337): E501 line too long (86 > 79 characters)
[Line 356:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L356): E501 line too long (83 > 79 characters)
[Line 357:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L357): E501 line too long (84 > 79 characters)
[Line 358:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L358): E501 line too long (85 > 79 characters)
[Line 359:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L359): E501 line too long (83 > 79 characters)
[Line 360:80](https://github.com/prateekiiest/Code-Sleep-Python/blob/73c9ba9a6cf975877f85ec102c97b00f7c840e47/Code-Sleep-Python/Inception TicTacToe/inceptionTTT.py#L360): E501 line too long (85 > 79 characters)

Comment last updated on July 31, 2018 at 12:51 Hours UTC

@molex
Copy link
Contributor Author

molex commented May 12, 2018

ok, had to make some additional changes to my IDE to catch some of these PEP violations. I have resubmitted.

@prateekiiest
Copy link
Owner

prateekiiest commented May 12, 2018

some issues with code climate

@stale
Copy link

stale bot commented Jun 6, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 6, 2018
@stale stale bot closed this Jun 13, 2018
@prateekiiest prateekiiest reopened this Jun 29, 2018
@stale stale bot removed the wontfix label Jun 29, 2018
@prateekiiest
Copy link
Owner

prateekiiest commented Jun 29, 2018

@molex any updates on this?

@stale
Copy link

stale bot commented Jul 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 24, 2018
@stale stale bot closed this Jul 31, 2018
@prateekiiest
Copy link
Owner

prateekiiest commented Jul 31, 2018

I am merging this as of now

@prateekiiest prateekiiest reopened this Jul 31, 2018
@stale stale bot removed the wontfix label Jul 31, 2018
@prateekiiest prateekiiest merged commit c53cc05 into prateekiiest:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@molex @pep8speaks @prateekiiest