Correct the auto-merge token rationale comment - #27
Merged
Conversation
The previous comment claimed GITHUB_TOKEN is unavailable to reusable workflows, which is not true. The actual reason the app token is reused is that branch protection on main restricts pushes to the praw-dev-automation app, so github-actions[bot] cannot complete the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only change to the
pre-commit_autoupdatereusable workflow; no behavior change.The comment added in #26 claimed the app token is reused because
GITHUB_TOKENis not available to reusable workflows. That is false — reusable workflows do receivegithub.token.The real reason is branch protection:
mainrestricts pushes to thepraw-dev-automationapp (users: [],teams: []).GITHUB_TOKENacts asgithub-actions[bot], which is not on that allowlist and therefore cannot complete the merge. The app token is the only identity that can.Worth recording accurately, since the wrong rationale invites a future 'least privilege' swap to
GITHUB_TOKENthat would silently break auto-merge.