Remove concurrency from the reusable lint workflow - #37
Merged
Conversation
Declaring workflow-level concurrency in a reusable workflow made every workflow_call of it fail at startup: no jobs ran, no logs were produced, and no check run was created, so the failure was invisible in PR checks and never blocked a merge. actionlint and zizmor have therefore not run in any caller repository since 2026-06-15, when the callers moved to v1.6.0. Callers already declare their own concurrency group, so nothing is lost. Verified by pointing CodeSorter's caller at this change: the run started and both jobs completed, where the same caller had produced a startup failure.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a silent breakage:
Lint workflowshas failed at startup in every caller repo since 2026-06-15, so actionlint and zizmor have not run on praw, prawcore, asyncpraw, asyncprawcore, CodeSorter, or praw-release for nearly two months.Cause
v1.6.0 added a workflow-level
concurrencyblock to the reusablelint.yml. Callers already declare the samelint-${{ github.ref }}group and then call this workflow, which declares it again. Called that way, the run fails at startup — no jobs, no logs, and no check run, which is why it never appeared ingh pr checksand never blocked anything. The workflow still ran fine in-repo, which masked it further.Timeline: last success 2026-06-15T17:29Z; first failure 17:29 → 18:02Z, the minute the callers were bumped to v1.6.0. Every run since has failed.
Verification
Pointed CodeSorter's lint caller at this change (run 31614199429): the run started and both
actionlintandzizmorcompleted successfully, versus a startup failure with zero jobs on the same caller minutes earlier.Nothing is lost — every caller declares its own concurrency group.