Sync meta config with praw - #17
Merged
Merged
Conversation
bboe
force-pushed
the
sync-meta-with-praw
branch
2 times, most recently
from
June 13, 2026 22:41
e1dbd1b to
e0ece49
Compare
Align CodeSorter's tooling/metadata with the praw-dev conventions, keeping CodeSorter's intentional differences (strict pyright, the CLI entry point, no network-test deps). ruff: - select = ["ALL"]; base the global ignore on the leaner prawcore core-lib list, then trim it to the rules that fire or are tooling mandated (down to 7 entries) - keep C901 as an inline noqa on _get_dependencies rather than a global ignore - make the CLI's main() callback keyword-only, which eliminates the FBT001 and PLR0917 ignores; PLR0913 (one parameter per click option) remains as a lone cli.py per-file ignore - minimize the remaining per-file-ignores to what actually fires - add the flake8-builtins ignorelist - source fixes surfaced by the above: PERF401 (list.extend) and dropping the RUF015 noqa via next(iter(...)) packaging / metadata: - add the codesorter/py.typed marker and the 'Typing :: Typed' classifier - add the 'Change Log' project URL -> the Read the Docs change log page tox / deps / pre-commit: - add 'docs' to the tox envlist - pass SKIP through to the pre-commit env (pass_env) - add ruff to the lint dependency group - add the sort-simple-yaml hook for workflow / .readthedocs YAML Coverage enforcement (fail_under=100) is deferred to a follow-up that adds the missing cli.py test suite.
bboe
force-pushed
the
sync-meta-with-praw
branch
from
June 13, 2026 22:46
e0ece49 to
330d668
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns CodeSorter's tooling/metadata with the praw conventions, per the agreed scope. Kept CodeSorter's intentional differences: strict pyright (praw is standard), the
[project.scripts]CLI entry point, and no network-test deps (vcrpy/requests).ruff
select = ["ALL"]with praw's curatedignorelist (replaces the explicit allow-list) +flake8-builtinsignorelist (id).docs/conf.pyandtests/*.pyper-file-ignores to praw's category-level style.ALL:PERF401→ uselist.extendin_gen_unique_name.packaging / metadata
codesorter/py.typedmarker +"Typing :: Typed"classifier (the package is fully typed; verifiedpy.typedships in the wheel)."Change Log"project URL → the RTD change log page.tox / deps / pre-commit
docsadded to the toxenvlist(baretoxnow builds docs).pass_env = ["SKIP"]instead of hardcodingset_env.SKIP(matches how the shared CI passesSKIP).ruffadded to thelintdependency group.sort-simple-yamlpre-commit hook for workflow /.readthedocsYAML (existing workflows were already in order, so no reformat).Deferred (separate follow-up)
Coverage enforcement (
fail_under=100) is not in this PR.cli.pyis only 23% covered — the CLI has no tests — so 100% needs a dedicated CLI test suite, which I'll do next, then flip on the gate.Verified: ruff clean under
ALL, pyright strict 0 errors, 15 tests pass, pre-commit clean, docs build clean.