fix(conversations): avoid per-call String allocation in normalize_message_item#391
Merged
leseb merged 1 commit intoJul 16, 2026
Conversation
|
Unsigned commits: a713ddc. Please sign your commits. |
Nitjsefnie
force-pushed
the
fix/357-normalize-message-item-alloc
branch
from
July 16, 2026 09:55
a713ddc to
cc4fe85
Compare
…sage_item Co-Authored-By: Kimi K2.7 Code <noreply@kimi.com> Signed-off-by: Nitjsefnie <zmatek.peter@gmail.com>
leseb
approved these changes
Jul 16, 2026
leseb
enabled auto-merge
July 16, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-call
Stringallocation innormalize_message_itemwith a borrowed string comparison viaValue::as_str. The old and new expressions behave identically for missing or non-stringtypevalues.Verification gates run on
praxis-ai-apis:cargo +nightly fmt -p praxis-ai-apis— passedcargo clippy -p praxis-ai-apis --all-targets -- -D warnings— passedcargo test -p praxis-ai-apis— passedCloses #357
Prepared with AI assistance (Kimi K2.7 Code), human-reviewed before submission.