Detect single backticks at the start of the line#24
Merged
asottile merged 5 commits intopre-commit:masterfrom Jan 11, 2020
Merged
Detect single backticks at the start of the line#24asottile merged 5 commits intopre-commit:masterfrom
asottile merged 5 commits intopre-commit:masterfrom
Conversation
Member
|
awesome -- thanks for the patch! can you add a quick test to https://github.com/pre-commit/pygrep-hooks/blob/master/tests/hooks_test.py demoing this change? |
Contributor
Author
|
@asottile i added tests. |
asottile
reviewed
Jan 11, 2020
tests/hooks_test.py
Outdated
| r" `JPdzQ2QqF_AQl=t]`", | ||
| r" `97P}j:' :MJhH,JnFCVlE\"pX cM/j6!s:=69Wf>Yc[5mb9z)W?Hb5m{Lt,)f,&x<mr'C3NBDMnr6<'|-b6`>", | ||
| r" `@ ~7JyWy/V9V<th:}y.#``S", | ||
| r" `- 3]1f{I**4Q).6}/#BrEPW.2^v]4n6oia8Xu_fOgh:q_E9Qxp}n:p T)*EId99,[7w^&AX(uQ_7~$)DX*z=t].qLh+ON>sMOt}`", |
Member
There was a problem hiding this comment.
I'm not interested in this test, please remove it -- tests should be obvious from reading what they are testing -- this one is nonsense
Member
|
thanks! this has been released as v1.4.4 🎉 |
Contributor
Author
|
What is the ETA for v1.4.4? I would like to update in my project. |
Member
|
negative four minutes ;) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I am working on the Apache Airflow project and one hook did not detect one error, so I am sending the patch.
Best regards,
Kamil