Skip to content

Fix typo in npm run serve --server#602

Merged
developit merged 1 commit intopreactjs:masterfrom
DanielApt:patch-1
Aug 6, 2018
Merged

Fix typo in npm run serve --server#602
developit merged 1 commit intopreactjs:masterfrom
DanielApt:patch-1

Conversation

@DanielApt
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Changed
npm run serve -- --server config to
npm run serve --server config in README.md

Did you add tests for your changes?
Not needed.

Summary
Remove typo from README.md

Does this PR introduce a breaking change?
No.

Other information
Not needed.

Unneeded `-- ` characters
Copy link
Copy Markdown
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@developit developit merged commit 7ed39aa into preactjs:master Aug 6, 2018
@ForsakenHarmony
Copy link
Copy Markdown
Member

Does this work with npm now? I know it does with yarn

@lukeed
Copy link
Copy Markdown
Member

lukeed commented Aug 6, 2018

Tested a series of npm run * commands in 6.1 and 6.3 versions of npm, the -- spacer is still needed.

@developit
Copy link
Copy Markdown
Member

Apologies, I merged this in error. npm run server -- --server config is still correct.

@lukeed
Copy link
Copy Markdown
Member

lukeed commented Aug 6, 2018

You are forgiven.

developit added a commit that referenced this pull request Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants