Add support for arrays with holes as placeholders #1440
Add support for arrays with holes as placeholders #1440marvinhagemeister merged 23 commits intomasterfrom
Conversation
d730866 to
1ff8333
Compare
|
@marvinhagemeister Are you sure that this PR fixes (#1343)?, I tried your changes, But it still occurred!. |
|
FYI, I have a review pending that I hope to finish today |
|
@Almo7aya you're right it doesn't fix it. Removed the mention from the original post. |
29488e8 to
a9db477
Compare
a9db477 to
caa69b0
Compare
|
I found another way to modify
Or in a nutshell: Don't match anything stateful. This has a size cost though. The PR went up from |
b94418b to
fccfd54
Compare
fccfd54 to
d7c6c7d
Compare
JoviDeCroock
left a comment
There was a problem hiding this comment.
This looks really good, I think this is a good justification for the added bytes
|
Waiting on #1515 to be merged first. That one will fix the remaining |
d7c6c7d to
7d20cc3
Compare
d51adff to
f8c061f
Compare
2eb17c8 to
318a7b3
Compare
|
@andrewiggins I've completely reworked my reconciliation strategy. You were right all along that the previous changes were moving into the wrong direction 👍 Would love if you can take another look at this PR 🎉 |
This reverts commit 2c66435.
JoviDeCroock
left a comment
There was a problem hiding this comment.
This looks superb, I can't think of scenario's where implications could arise :D nice work, really seeing this PR grow was awesome 💯
This PR adds support for tagging empty positions in an array of children. This is best illustrated with the following snippet:
The most obvious use case is conditional rendering like in the snippet above. With holes we can effectively skip a lot of work by matching indexes directly.
On top of that the PR includes the following changes:
Fixes #1327 , Fixes #753 , Fixes #857 .
Adds
+27 B+51 B+44 B+31 B+30 B🎉