Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -289 B (-0.37%) Total Size: 78.7 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
core-size-optimizations
branch
from
efdaaef to
f084a74
Compare
developit
reviewed
Feb 13, 2026
src/diff/index.js
Outdated
| for (let i = 0; i < c._stateCallbacks.length; i++) { | ||
| c._renderCallbacks.push(c._stateCallbacks[i]); | ||
| } | ||
| c._renderCallbacks.push(...c._stateCallbacks); |
Member
There was a problem hiding this comment.
Ran a couple quick tests, (the transpiled output) seems to actually be marginally faster in Chrome & only slightly slower in FF. Not sure about Safari.
Of course it doesn't stay as a spread, actually becomes .push.apply():
($ = h.__h).push.apply($, h._sb)
Member
Author
There was a problem hiding this comment.
In all of my benchmarks it was better, the larger the array the faster it is. The size optimisation feels so worth it to me
Member
There was a problem hiding this comment.
Oh I didn't realize it would be transpiled in our config, thanks @rschristian
Yeah I'm that case I'm totally good with this.
Member
There was a problem hiding this comment.
One option maybe worth checking the size of given the transpiled output:
EMPTY_ARR.push.apply(c._renderCallbacks, c._stateCallbacks);
I suspect that may be smaller and faster than the transpiled spread if used everywhere, since it has more repetition and avoids a property read.
rschristian
approved these changes
Feb 14, 2026
developit
approved these changes
Feb 16, 2026
Member
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
LGTM would love to check on that global push method for size before merge tho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.