Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -146 B (-0.19%) Total Size: 78.6 kB
ℹ️ View Unchanged
|
Member
|
Need to take a better look after work, but might also address #3929 |
Member
Author
|
A different implementation might be to do let flush;
options.debounceRendering = (fn) => {
flush = fn;
queueMicroTask(fn);
}
export function flushSync(cb) {
let res = cb();
flush();
return res;
} |
JoviDeCroock
requested review from
andrewiggins,
developit,
marvinhagemeister and
rschristian
rschristian
reviewed
Feb 24, 2026
Member
There was a problem hiding this comment.
I don't mean to be picky but this PR seems to have a considerable amount of miscellaneous golfing, it might even make up the bulk of the changes. If it's not too much of a hassle, I'd generally prefer that to be extracted out & separate.
As-is, it's bundle fairly different things and muddying up the diff.
Member
Author
|
I tried doing our old habit again of compensating for the bytes we added but I'll separate it out. |
Merged
This reverts commit 001bbce.
rschristian
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.