[Proposal] remove legacy context#5142
Closed
JoviDeCroock wants to merge 1 commit into
Closed
Conversation
Drops support for getChildContext/legacy context propagation. Context providers (createContext and compat's portal ContextProvider) now publish child context via an internal, mangled _childContext property instead of the public getChildContext method. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
Size Change: -39 B (-0.08%) Total Size: 48 kB 📦 View Changed
ℹ️ View Unchanged
|
Member
Author
|
The impact of this was a lot lower than I had hoped 😅 |
|
coverage: 98.528%. remained the same — proposal/remove-legacy-context into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 removed it and it does look like it saves bytes/improves perf
Measured: -9 B gzipped on core (
dist/preact.mjs).createContextand compat portals now publish context through an internal mangled_childContextproperty; the publicgetChildContextmethod is no longer called.🤖 Generated with Claude Code