Skip to content

Fix reusing template element content - #5192

Merged
JoviDeCroock merged 2 commits into
mainfrom
JoviDeCroock/issue-4732-fix
Aug 6, 2026
Merged

Fix reusing template element content#5192
JoviDeCroock merged 2 commits into
mainfrom
JoviDeCroock/issue-4732-fix

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fixes #4732

This ensures that we use the templated children

@github-actions

github-actions Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-2.86ms - +6.16ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +2% (-0.40ms - +1.20ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.58ms - +0.21ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +0% (-1.04ms - +0.20ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +4% (-0.08ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.06ms - +0.37ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +1% (-1.62ms - +0.51ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +3% (-0.22ms - +0.17ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.05ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local845.68ms - 851.82ms-unsure 🔍
-0% - +1%
-2.86ms - +6.16ms
preact-main843.80ms - 850.41msunsure 🔍
-1% - +0%
-6.16ms - +2.86ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.23ms - 19.27ms-unsure 🔍
-0% - +0%
-0.02ms - +0.03ms
preact-main19.23ms - 19.26msunsure 🔍
-0% - +0%
-0.03ms - +0.02ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.54ms-unsure 🔍
-0% - +0%
-0.03ms - +0.04ms
preact-main16.49ms - 16.54msunsure 🔍
-0% - +0%
-0.04ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.57ms - 1.57msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local48.20ms - 49.47ms-unsure 🔍
-1% - +2%
-0.40ms - +1.20ms
preact-main47.94ms - 48.92msunsure 🔍
-2% - +1%
-1.20ms - +0.40ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.00ms - 5.25ms-unsure 🔍
-4% - +3%
-0.22ms - +0.17ms
preact-main5.00ms - 5.30msunsure 🔍
-3% - +4%
-0.17ms - +0.22ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local15.90ms - 16.46ms-unsure 🔍
-4% - +1%
-0.58ms - +0.21ms
preact-main16.09ms - 16.65msunsure 🔍
-1% - +4%
-0.21ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.77ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.76ms - 3.76msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #5790

  • Commit: 2b9d2e7

duration

VersionAvg timevs preact-localvs preact-main
preact-local43.63ms - 44.41ms-unsure 🔍
-2% - +0%
-1.04ms - +0.20ms
preact-main43.96ms - 44.92msunsure 🔍
-0% - +2%
-0.20ms - +1.04ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.04ms - 3.06ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.04ms - 3.05msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local20.64ms - 21.20ms-unsure 🔍
-2% - +1%
-0.46ms - +0.31ms
preact-main20.73ms - 21.26msunsure 🔍
-2% - +2%
-0.31ms - +0.46ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local23.55ms - 24.41ms-unsure 🔍
-1% - +4%
-0.14ms - +1.04ms
preact-main23.13ms - 23.93msunsure 🔍
-4% - +1%
-1.04ms - +0.14ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local23.64ms - 24.51ms-unsure 🔍
-2% - +3%
-0.40ms - +0.81ms
preact-main23.45ms - 24.29msunsure 🔍
-3% - +2%
-0.81ms - +0.40ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local19.34ms - 19.53ms-unsure 🔍
-1% - +1%
-0.15ms - +0.10ms
preact-main19.38ms - 19.55msunsure 🔍
-1% - +1%
-0.10ms - +0.15ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.79ms - 22.57ms-unsure 🔍
-3% - +2%
-0.74ms - +0.38ms
preact-main21.96ms - 22.76msunsure 🔍
-2% - +3%
-0.38ms - +0.74ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local15.50ms - 15.86ms-unsure 🔍
-3% - +1%
-0.42ms - +0.13ms
preact-main15.61ms - 16.03msunsure 🔍
-1% - +3%
-0.13ms - +0.42ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 150
  • Built by: CI #5790

  • Commit: 2b9d2e7

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.75ms - 1.86ms-unsure 🔍
-4% - +4%
-0.08ms - +0.08ms
preact-main1.75ms - 1.86msunsure 🔍
-4% - +4%
-0.08ms - +0.08ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.04ms - 1.09ms-unsure 🔍
-5% - +3%
-0.05ms - +0.03ms
preact-main1.05ms - 1.11msunsure 🔍
-3% - +5%
-0.03ms - +0.05ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.99ms - 30.22ms-unsure 🔍
-0% - +1%
-0.06ms - +0.37ms
preact-main29.77ms - 30.13msunsure 🔍
-1% - +0%
-0.37ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.49ms - 34.97ms-unsure 🔍
-5% - +1%
-1.62ms - +0.51ms
preact-main34.03ms - 35.54msunsure 🔍
-2% - +5%
-0.51ms - +1.62ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.98ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Size Change: +2 B (+0.01%)

Total Size: 15.9 kB

📦 View Changed
Filename Size Change
dist/preact.mjs 5 kB +2 B (+0.04%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.88 kB
debug/dist/debug.mjs 3.88 kB
devtools/dist/devtools.mjs 274 B
hooks/dist/hooks.mjs 1.5 kB
jsx-runtime/dist/jsxRuntime.mjs 861 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Aug 5, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 99.289%. remained the same — JoviDeCroock/issue-4732-fix into main

@JoviDeCroock
JoviDeCroock merged commit cfaa1b9 into main Aug 6, 2026
13 checks passed
@JoviDeCroock
JoviDeCroock deleted the JoviDeCroock/issue-4732-fix branch August 6, 2026 13:49
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes
@rschristian rschristian Awaiting requested review from rschristian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: <template> tag content rendered twice

3 participants

@JoviDeCroock @coveralls @marvinhagemeister