fix: keep the pending error flag until the boundary's retry render - #5227
Merged
Conversation
📊 Tachometer Benchmark ResultsSummary⏳ Benchmarks are currently running. Results below are out of date. duration
usedJSHeapSize
Results⏳ Benchmarks are currently running. Results below are out of date. create10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +4 B (+0.03%) Total Size: 15.9 kB 📦 View Changed
ℹ️ View Unchanged
|
|
coverage: 99.534%. remained the same — JoviDeCroock/fix-error-boundary-retry-loop into main |
marvinhagemeister
approved these changes
Sep 2, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR was authored by an LLM (Claude Fable 5.1) during the v11 release-readiness audit; Jovi reviewed the change and the tests.
Summary
When a descendant throws and a boundary handles it,
_catchErrorsetsPENDING_ERRORon the boundary from inside the boundary's owndiffChildrencall. Since 943fa26 the end ofdiff()clearsPROCESSING_EXCEPTION | PENDING_ERRORunconditionally, so that bit is wiped in the same render that set it. On the retry render the boundary is therefore never markedPROCESSING_EXCEPTION, catches the same error again, enqueues another retry, and loops: one microtask per iteration, forever. A boundary that retries on error hangs the tab instead of letting the error bubble.v10 captured
clearProcessingException = c._pendingErrorbefore rendering and only cleared at the end when it was set at the start. This restores that: the bits are cleared only when the render began as the retry.Test
should skip the boundary when the retry render throws againincomponentDidCatch.test.jsx: onmainthererender()call never returns (the test runner hangs); here the second error bubbles to the outer boundary and the inner one catches exactly once.Core brotli: 4428 → 4426 B.