Correct the definition of ComponentLifecycle - #740
Merged
Conversation
Member
|
Awesome to see a core contributer of the TypeScript team here! I've always struggled with the different concept of values and declarations in the past, and your explanation nails it 👍 |
jamesbirtles
approved these changes
Jun 28, 2017
robertknight
approved these changes
Jun 29, 2017
robertknight
left a comment
robertknight
left a comment
Member
There was a problem hiding this comment.
Thank-you very much for this @RyanCavanaugh 👍
Contributor
|
Can we push a release of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no value named
ComponentLifecycle, so this should be represented as an interface rather than a class.The correct way to copy down the optional members of an interface into a class declaration is to use declaration merging (see diff).