create-wmr: template dep versions automatically kept up-to-date#582
create-wmr: template dep versions automatically kept up-to-date#582marvinhagemeister merged 1 commit intomainfrom
Conversation
|
| // @ts-ignore-next | ||
| await getPackageManager({ prefer: packageManager }).catch(() => { | ||
| process.stderr.write(`\n${red(`${packageManager} cannot be found`)}\n`); | ||
| process.exit(1); | ||
| }); |
There was a problem hiding this comment.
I believe I wrote this because installing with yarn was originally a flag, like used in preact-cli. This is irrelevant though with the current set up. You can't run npm init / yarn create without having npm/yarn available. NPX comes with NPM, so it too isn't an potential issue.
marvinhagemeister
left a comment
marvinhagemeister
left a comment
There was a problem hiding this comment.
Sweeeet 🙌 🎉 Let's add a changeset and merge this 👍
|
Does this need a changeset? Shouldn''t actually change anything for users, just reduces maintenance burden. I'm still not clear on the lines between needing a changeset vs not 😅 |
|
Good point, I don't really have a strong opinion on this 😬 |
|
I suppose it does alter user code but idk where the distinction is there |
|
Yeah it's pretty blurry and I don't think there is a right or wrong approach here. It's more of an opinion which way we pick. |
2 participants
So as it turns out,
pkg-installdoes in fact write to thepackage.jsonfile.... so long as you remember to scaffold your project before installing 🙃create-wmrnow installs the very latest versions of the deps and it will end up in the user's package file in the form of"^x.x.x"