Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,23 @@
import java.util.HashSet;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.Set;
import java.util.function.Function;
import java.util.stream.Collectors;

public class PrioritizedCoopSyncProvider {

private static final Logger logger = LoggerFactory.getLogger(PrioritizedCoopSyncProvider.class);

private final Set<String> prioritizedBidders;
private final Map<String, String> prioritizedCookieFamilyNameToBidderName;
private final Set<String> prioritizedCookieFamilies;

public PrioritizedCoopSyncProvider(Set<String> bidders, BidderCatalog bidderCatalog) {
this.prioritizedBidders = validCoopSyncBidders(Objects.requireNonNull(bidders), bidderCatalog);
this.prioritizedCookieFamilyNameToBidderName = prioritizedBidders.stream()
.collect(Collectors.toMap(
bidder -> bidderCatalog.cookieFamilyName(bidder).orElseThrow(),
Function.identity()));
this.prioritizedCookieFamilies = prioritizedBidders.stream()
.map(bidder -> bidderCatalog.cookieFamilyName(bidder).orElseThrow())
.collect(Collectors.toSet());
}

private static Set<String> validCoopSyncBidders(Set<String> bidders, BidderCatalog bidderCatalog) {
Expand Down Expand Up @@ -71,7 +68,6 @@ public Set<String> prioritizedBidders(Account account) {
}

public boolean isPrioritizedFamily(String cookieFamilyName) {
final String bidder = prioritizedCookieFamilyNameToBidderName.get(cookieFamilyName);
return prioritizedBidders.contains(bidder);
return prioritizedCookieFamilies.contains(cookieFamilyName);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import static java.util.Collections.singleton;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatNoException;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mock.Strictness.LENIENT;

Expand Down Expand Up @@ -47,6 +48,18 @@ public void creationShouldFilterInvalidPrioritizedBidders() {
assertThat(result).containsExactly("valid");
}

@Test
public void creationShouldAllowMultipleBiddersWithTheSameCookieFamilyName() {
// given
givenValidBidderWithCookieSync("bidder1", "cookie-family-name");
givenValidBidderWithCookieSync("bidder2", "cookie-family-name");
given(bidderCatalog.usersyncReadyBidders()).willReturn(Set.of("bidder1", "bidder2"));

// when and then
assertThatNoException().isThrownBy(() ->
new PrioritizedCoopSyncProvider(Set.of("bidder1", "bidder2"), bidderCatalog));
}

@Test
public void prioritizedBiddersShouldReturnSetWithPrioritizedBiddersFromAccount() {
// given
Expand Down Expand Up @@ -99,9 +112,14 @@ private void givenValidBiddersWithCookieSync(String... bidders) {
}

private void givenValidBidderWithCookieSync(String bidder) {
givenValidBidderWithCookieSync(bidder, null);
}

private void givenValidBidderWithCookieSync(String bidder, String cookieFamilyName) {
given(bidderCatalog.isValidName(bidder)).willReturn(true);
given(bidderCatalog.isActive(bidder)).willReturn(true);
given(bidderCatalog.cookieFamilyName(bidder)).willReturn(Optional.of(bidder + "-cookie-family"));
given(bidderCatalog.cookieFamilyName(bidder))
.willReturn(Optional.ofNullable(cookieFamilyName).or(() -> Optional.of(bidder + "-cookie-family")));
given(bidderCatalog.usersyncerByName(bidder)).willReturn(
Optional.of(Usersyncer.of(
"cookie-family-name",
Expand Down
Loading