Skip to content

Conversation

@JoelLarson
Copy link
Contributor

This removes the deprecated library as outlined in: preboot/angular-webpack#51

It uses a different module than the one specified in the issue above, but it does not require more dependencies than itself.

@escapedcat
Copy link
Contributor

This was helpful to me and I think it should be merged.
@JoelLarson you might want to modify the comment as well to something like:

  // ISTANBUL LOADER
  // https://github.com/deepsweet/istanbul-instrumenter-loader
  // Instrument JS files with istanbul-lib-instrument for subsequent code coverage reporting
  // Skips node_modules and files that end with .test.js

@escapedcat
Copy link
Contributor

@phra
Copy link
Member

phra commented Nov 23, 2016

@escapedcat when @JoelLarson will merge your PR i will merge this to into the upstream.

Update istanbul-loader comment
@phra phra merged commit 4d25b11 into preboot:master Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants