Add a workflow to trigger the system tests#259
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GHA workflow to trigger the system tests by adding the
trigger-system-testslabel.Note that, due to the way we source the bindings in the
requirements.txt, for PRs from forks (only), building will test the right version of the bindings, but running the tests will fail as it will not be able to find the commit from the fork on the main repository.I am not sure how to further improve that, but see precice/tutorials#881 and precice/tutorials#858 for details. Any fixes only need to be submitted to the tutorials repository, so this PR is ready to go.
A workaround in the case of a PR from a fork is to push a copy of the respective branch in the main repository and manually trigger the system tests.