Skip to content

Conversation

@medhatphq
Copy link
Contributor

  • Modify features endpoint schema to dynamically set requested features so we don't have to explicitly update the schema when new features are implemented.

Copy link
Member

@CockyAmoeba CockyAmoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 👍

Copy link
Contributor

@lpouvreau lpouvreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks @medhatphq 🙂

@hhheath
Copy link
Contributor

hhheath commented Jul 16, 2024

hey @medhatphq things seem to be working better now, but I am now getting all stats instead of just the ones requested.
image
image

@medhatphq
Copy link
Contributor Author

hey @medhatphq things seem to be working better now, but I am now getting all stats instead of just the ones requested.

Discusssed with @hhheath and we agreed the right solution to hiding None values is to use .model_dump(exclude_none=True) when serialising feature data.

The other solution is to explicitly access the requested fields only, as documented in the README and usecases.

We also agreed that I will add notes in the README and usecases to document the usage of model_dump(exclude_none=True)

@medhatphq medhatphq merged commit 5f57567 into master Jul 17, 2024
@medhatphq medhatphq self-assigned this Jul 17, 2024
@medhatphq medhatphq deleted the SE-1356-fix-features-api-response branch July 17, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants