[PRE-417] Use field alias to avoid Pydantic schema shadow warning - #22
Merged
joshgillies merged 1 commit intoAug 4, 2026
Conversation
QualitySchemaForCreate and QualitySchemaDetails use schema_ as the field name with an alias of 'schema' so the API JSON payload stays unchanged. populate_by_name=True lets callers construct models with either schema or schema_. Also bumps ty from 0.0.29 to 0.0.66 to support Field(alias=...) type checking.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThe PR updates Prefactor API URLs across documentation and examples, renames quality schema model attributes to ChangesAPI URL updates
Quality schema model compatibility
Development tooling update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
joshgillies
marked this pull request as ready for review
August 4, 2026 04:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QualitySchemaForCreateandQualitySchemaDetailsuseschema_as the field name with an alias of 'schema' so the API JSON payload stays unchanged.populate_by_name=Truelets callers construct models with eitherschemaorschema_.Also bumps ty from 0.0.29 to 0.0.66 to support
Field(alias=...)type checking.Summary by CodeRabbit
Documentation
Improvements
schemaformat.