fix(firestartr-bootstrap): handle modern GitHub API permission values in collaborator check - #478
Open
ricardosacristan wants to merge 3 commits into
Open
fix(firestartr-bootstrap): handle modern GitHub API permission values in collaborator check#478ricardosacristan wants to merge 3 commits into
ricardosacristan wants to merge 3 commits into
Conversation
… in collaborator check
Contributor
There was a problem hiding this comment.
Pull request overview
Updates firestartr-bootstrap’s PAT validation to accept GitHub’s modern legacy base role permission strings returned by the collaborators permission endpoint, preventing false validation failures during bootstrap.
Changes:
- Treat
writeas sufficient write access in the collaborator permission check. - Treat
readas insufficient (read-only) access in the collaborator permission check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477