-
Notifications
You must be signed in to change notification settings - Fork 22
feat: change glob types #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change glob types #368
Conversation
|
ah yeah makes sense! |
|
I verfied that it works with the wax implementation as well. |
|
@baszalmstra yeah fyi unix glob normally matches
So:
But for wax it is the same as |
|
out of interest, is |
|
I think it should be yes. In our case at least. |
|
Test in suite this 'proves' (as far as those tests prove) backward compatibility. |
Hofer-Julian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, also great that you added comments to the existing logic!
Use the
**globs instead of*/**. The latter does not match files in the current directory for ignore and other glob implementations, wax was incorrect in that regard. We need this when switching to: prefix-dev/pixi#4578. (This PR is needed to fix build errors there).In draft until I verify the behavior completely.