Skip to content

fix!: implement feature activation environment precedence#5956

Merged
ruben-arts merged 2 commits intoprefix-dev:mainfrom
ruben-arts:feature/pix-1704-inconsistent-feature-order-precedence-between-task
Apr 24, 2026
Merged

fix!: implement feature activation environment precedence#5956
ruben-arts merged 2 commits intoprefix-dev:mainfrom
ruben-arts:feature/pix-1704-inconsistent-feature-order-precedence-between-task

Conversation

@ruben-arts
Copy link
Copy Markdown
Contributor

@ruben-arts ruben-arts commented Apr 24, 2026

Description

This is a breaking change! We're changing the logic of what environment variable takes precedence in the feature logic.

The activation.env variable logic was different from the other merging logic. Where the last feature would win instead of the first. This is now reversed in this PR.

Fixes #5926

How Has This Been Tested?

Tested the example in the issue.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@ruben-arts ruben-arts added breaking Breaks something in the api or config env-vars Related to environment variables labels Apr 24, 2026
@ruben-arts ruben-arts marked this pull request as ready for review April 24, 2026 11:51
@ruben-arts ruben-arts enabled auto-merge (squash) April 24, 2026 11:53
@ruben-arts ruben-arts merged commit c584507 into prefix-dev:main Apr 24, 2026
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaks something in the api or config env-vars Related to environment variables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent feature-order precedence between task resolution and activation.env variables

2 participants