Skip to content

refactor(run): report the assumed platform per environment - #6508

Merged
hunger merged 1 commit into
prefix-dev:mainfrom
hunger:push-wykzltwvsksk
Jul 29, 2026
Merged

refactor(run): report the assumed platform per environment#6508
hunger merged 1 commit into
prefix-dev:mainfrom
hunger:push-wykzltwvsksk

Conversation

@hunger

@hunger hunger commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The pixi run platform decision moved into the per-task loop (#6507), so the up-front base-environment logging no longer matched what actually ran: a bare pixi run would log "assuming platform linux-64" for the default environment while the task ran in a sibling at a richer platform.

Emit the "assuming platform" info per environment, keyed on the task's run environment and its resolved platform, and drop the verbose "Run-platform decision" debug line -- it only described the base environment's inputs and is no longer needed.

How Has This Been Tested?

By checking the logging output

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@hunger
hunger requested a review from wolfv July 2, 2026 16:12
@hunger

hunger commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Based on your comment to #6507: Yes, much of this can probably go now. Here is the cleanup for that.

I did not want to do that in the fix PR as it felt like refactoring and not like a fix, but that distinction is unnecessary when you release straight from main anyway :-)

The `pixi run` platform decision moved into the per-task loop (prefix-dev#6507), so
the up-front base-environment logging no longer matched what actually ran:
a bare `pixi run` would log "assuming platform linux-64" for the default
environment while the task ran in a sibling at a richer platform.

Emit the "assuming platform" info per environment, keyed on the task's run
environment and its resolved platform, and drop the verbose "Run-platform
decision" debug line -- it only described the base environment's inputs and
is no longer needed.
@hunger
hunger force-pushed the push-wykzltwvsksk branch from fb3548f to 5e10799 Compare July 13, 2026 11:24
@hunger
hunger requested a review from Hofer-Julian July 13, 2026 11:24
@hunger

hunger commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@wolfv Considering your more ambitious cleanup PR #6509 changes behavior in ways we do not want: Shall we merge this one? It is not changing behavior:-)

@hunger
hunger merged commit a8869cf into prefix-dev:main Jul 29, 2026
35 checks passed
@hunger
hunger deleted the push-wykzltwvsksk branch July 29, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants