fix: resolve rich platforms in workspace export conda-explicit-spec - #6551
Merged
hunger merged 3 commits intoJul 27, 2026
Merged
Conversation
lucascolley
reviewed
Jul 15, 2026
Comment on lines
+111
to
+118
| // Resolve the conda subdir to the environment's platform entry. Rich | ||
| // platforms (platforms carrying system-requirements) are stored in the lock | ||
| // file under generated aliases (e.g. `p1`, `p2`) rather than their subdir | ||
| // name, so we cannot look them up by `platform.to_string()`. Instead, match | ||
| // on the subdir of each platform the environment actually provides. | ||
| let lock_platform = | ||
| env.platforms() | ||
| .find(|p| p.subdir() == *platform) |
Collaborator
There was a problem hiding this comment.
Does this just match any rich platform of the same subdir? What if there are multiple?
hunger
approved these changes
Jul 27, 2026
hunger
left a comment
hunger
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into this!
Contributor
Author
|
@hunger @ruben-arts thanks for getting this fixed!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pixi workspace export conda-explicit-speclooked up platforms by conda subdir. Rich platforms are keyed in the lock file under generated aliases, so the lookup returnedNoneand the command failed withplatform 'osx-arm64' not found for env <env>.How Has This Been Tested?
On
mainthis errors withplatform 'osx-arm64' not found for env default. With only the lookup fixed it writes three subdir-named files, silently dropping four of the seven platforms. With this PR all seven are exported under their own names, and a subdir expands to every platform on it:AI Disclosure
Tools: Claude Code
Checklist:
schema/model.py.@MridulS, sorry for blundly taking over your PR but this should be a fix that works for all rich platforms now.