Skip to content

Switch to Pest#10

Merged
Hofer-Julian merged 7 commits intomainfrom
experiment_pest
Sep 2, 2024
Merged

Switch to Pest#10
Hofer-Julian merged 7 commits intomainfrom
experiment_pest

Conversation

@prsabahrami
Copy link
Copy Markdown
Contributor

@prsabahrami prsabahrami commented Aug 31, 2024

Closes #1 and Closes #2.
Error reporting needs improvement.
I was thinking maybe we could use miette for error reporting and I noticed there is an open PR for miette support on pest.
I think it would be interesting to explore miette for error reporting. Let me know what you think. I'd love to work on the open PR.

@prsabahrami prsabahrami requested a review from wolfv August 31, 2024 07:41
@Hofer-Julian
Copy link
Copy Markdown
Contributor

I think it would be interesting to explore miette for error reporting. Let me know what you think. I'd love to work on the open PR.

Upstreaming miette support to pest would be great!

@Hofer-Julian
Copy link
Copy Markdown
Contributor

@prsabahrami could you please revert the changed formatting settings and put them in a follow-up PR? All the unrelated changes make this a bit hard to review.

@prsabahrami
Copy link
Copy Markdown
Contributor Author

@prsabahrami could you please revert the changed formatting settings and put them in a follow-up PR? All the unrelated changes make this a bit hard to review.

Fair enough :))
Done.

@prsabahrami
Copy link
Copy Markdown
Contributor Author

I think it would be interesting to explore miette for error reporting. Let me know what you think. I'd love to work on the open PR.

Upstreaming miette support to pest would be great!

Couldn't agree more.
I'll start looking into it.

@Hofer-Julian
Copy link
Copy Markdown
Contributor

Fair enough :)) Done.

Thanks!

Copy link
Copy Markdown
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot @prsabahrami!

Also, pest is really cool, especially the online playground.

@Hofer-Julian Hofer-Julian merged commit ffec055 into main Sep 2, 2024
@Hofer-Julian Hofer-Julian deleted the experiment_pest branch September 2, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide on a parser Currently need ; to separate commands

2 participants