Add deterministic dataset candidate selection - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrainingRecordandTrainingSpancontract for Google and future enrichment sources.Invariants
retained_unique_candidatesdescribes only unique candidates surviving the bounded reservoirs.Without these rules, duplicate Wikipedia records could receive extra lottery tickets, common DATE/CARDINAL records could crowd out rare classes, and enrichment would need to construct a misleading Google-specific record type.
Validation
uv run pytest -q— 209 passeduv run ruff check src testsgit diff --checkThis PR does not add the Google shard adapter, enrichment, train/validation splitting, or final dataset writing.