fix: expand money realizer coverage - #39
Merged
aryamantodkar merged 2 commits intoAug 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$andUSDare equivalent, but$,CAD,A$, and other currencies are not interchangeable.tomorrow,weight, oronlyare rejected.Invariants
A complete MONEY span must produce a deterministic semantic amount and currency when its spoken value is valid. Display aliases remain evaluation-only and do not expand runtime candidates. Evaluation compares both normalized amount and currency identity.
Audit evidence
All seven Google TN shards were rerun: 214,728 MONEY rows total, with 21,239 exact and 191,379 identity-aware representation-equivalent results. The 2,047 mismatches are underdetermined annotations where generic spoken
dollar/centis paired with an explicit non-USD target such asA$or€; the source does not identify that currency. The 63Nonerows are malformedsil/paannotations. The remaining 212,618 determinate, non-malformed rows have 100% exact-or-equivalent coverage.Validation
uv run ruff format --check .uv run ruff check .uv run pytest(6 passed)cargo fmt --manifest-path rust/Cargo.toml -- --checkcargo test --manifest-path rust/Cargo.toml(40 passed)uv build