Skip to content

Upgrade go deps#927

Merged
mfridman merged 5 commits intomainfrom
mf/bump-deps
Mar 28, 2025
Merged

Upgrade go deps#927
mfridman merged 5 commits intomainfrom
mf/bump-deps

Conversation

@mfridman
Copy link
Copy Markdown
Collaborator

No description provided.

@mfridman
Copy link
Copy Markdown
Collaborator Author

Need to update golangci-lint

@k2589
Copy link
Copy Markdown
Contributor

k2589 commented Mar 24, 2025

Do you need any help?

@k2589
Copy link
Copy Markdown
Contributor

k2589 commented Mar 24, 2025

Need to update golangci-lint

Linter config is for v2
golangci/golangci-lint-action is now installing v1.64.8 for lates, but not v2 of golangci-lint

Mb try to set in action v2?

      - name: golangci-lint
        uses: golangci/golangci-lint-action@v6
        with:
          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
          version: v2.0.0
          github-token: ${{ secrets.GITHUB_TOKEN }}
          args: --timeout=2m --verbose

@mfridman
Copy link
Copy Markdown
Collaborator Author

I merged the dependabot upgrades manually and will deal with golangci-lient when the dust settles.

@ippoippo
Copy link
Copy Markdown

Hello @mfridman
Sorry to pester. Do you have an ETA on when you expect to work on this (or is there an external dependency issue you are waiting on).

Reason I'm asking is so that we can plan around your next tagged release.

Thanks 🙇

@mfridman
Copy link
Copy Markdown
Collaborator Author

I'll do it tonight, so let's say within the next 24 hours.

@ippoippo
Copy link
Copy Markdown

I'll do it tonight, so let's say within the next 24 hours.

Ohh. Thanks. Really appreciate the prompt response 🙇

# Conflicts:
#	Makefile
#	go.mod
#	go.sum
#	internal/testing/go.sum
#	lock/postgres.go
#	lock/session_locker_options.go
@mfridman mfridman merged commit a31731d into main Mar 28, 2025
4 checks passed
@mfridman mfridman deleted the mf/bump-deps branch March 28, 2025 01:36
@mfridman
Copy link
Copy Markdown
Collaborator Author

Cut a new release, updated golangci-lint, cleaned up the code and resolved the security issues.

https://github.com/pressly/goose/releases/tag/v3.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants