Document Special Defense badge boost glitch - #651
Merged
Conversation
Member
|
While we're at it, the header says: But RisingBadge does not boost Special Defense. |
Rangi42
self-requested a review
September 26, 2019 21:38
Rangi42
reviewed
Sep 26, 2019
|
|
||
| ## Glacier Badge may not boost Special Defense depending on the value of Special Attack | ||
|
|
||
| As Pryce's dialogue ("That BADGE will raise the SPECIAL stats of POKéMON.") implies, Glacier Badge is intended to boost both Special Attack and Special Defense. However, due to BoostStat overwriting `a` when boosting Special attack, the Special Defense boost will not happen if the unboosted Special Attack stat is either 0 ~ 205, or 433 ~ 660. |
Member
There was a problem hiding this comment.
Nitpick: nowhere else uses "dialogue", always "dialog".
Rangi42
reviewed
Sep 26, 2019
|
|
||
| ## Glacier Badge may not boost Special Defense depending on the value of Special Attack | ||
|
|
||
| As Pryce's dialogue ("That BADGE will raise the SPECIAL stats of POKéMON.") implies, Glacier Badge is intended to boost both Special Attack and Special Defense. However, due to BoostStat overwriting `a` when boosting Special attack, the Special Defense boost will not happen if the unboosted Special Attack stat is either 0 ~ 205, or 433 ~ 660. |
Member
There was a problem hiding this comment.
"Special attack" -> "Special Attack"
Rangi42
reviewed
Sep 26, 2019
|
|
||
| ## Glacier Badge may not boost Special Defense depending on the value of Special Attack | ||
|
|
||
| As Pryce's dialogue ("That BADGE will raise the SPECIAL stats of POKéMON.") implies, Glacier Badge is intended to boost both Special Attack and Special Defense. However, due to BoostStat overwriting `a` when boosting Special attack, the Special Defense boost will not happen if the unboosted Special Attack stat is either 0 ~ 205, or 433 ~ 660. |
Member
There was a problem hiding this comment.
"0-205 or 433-660" would match the range notation used elsewhere.
Member
|
Good find! I thought we had identified all the bugs, but no. |
Contributor
Author
|
Thanks for checking! All fixed. |
Rangi42
approved these changes
Sep 27, 2019
DeeDeeG
pushed a commit
to DeeDeeG/pokecrystal
that referenced
this pull request
Oct 21, 2019
Document Special Defense badge boost glitch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #643 (comment).