Remove unreferenced yellow files and renamed all H_ constants#166
Remove unreferenced yellow files and renamed all H_ constants#166vcvtne2ps2bf16 wants to merge 2 commits into
Conversation
14258dc to
7723281
Compare
|
As always, I don't speak for everyone, but I don't think these are useful changes. The same goes for the Yellow-specific song files, although this point is a little weak since the most up-to-date version of those song files can be found in the pokeyellow repo. Lastly, the reason that WRAM labels are named like |
|
I understand the reason to keep the unref'd files, but i have some doubts about the H_ renaming argument: what i want to do with that commit is to make hram constants naming consistent, since a few of these constants still use the old naming scheme of H_ADDRESSNAME, and using hAddressName make it clear that these constants are used as addresses I also think that what define a constant is the EQU keyword, not whether it's capitalized or not |
|
Ah, I see now that hram constants in hram.asm are more inconsistent than I thought. I didn't realize that already more than half of the constants were converted from H_* to h* in 2014/2015. |
|
The alternative is using |
|
I think pic/rgmon/ should stay since there's no other repo with these graphics. |
|
I know this is a bump, but the PR is still open. Another problem with using constants is that they're not included in the generated SYM files. When trying to debug the game (which is not dying thanks to ROM hacks and other projects), it's a bit of a bummer. To sum it up:
Thus, I would like to bring up again the HRAM change -- as standalone, though. Imo the pic/ folder is another debate. |
|
Is this still necessary? |
Also renamed pic/bmon to pic/mon