Skip to content

Fix issue #370 - A Newline too many in class statements#371

Merged
alexander-akait merged 1 commit intoprettier:masterfrom
winged:fix_370
Apr 10, 2018
Merged

Fix issue #370 - A Newline too many in class statements#371
alexander-akait merged 1 commit intoprettier:masterfrom
winged:fix_370

Conversation

@winged
Copy link
Copy Markdown
Contributor

@winged winged commented Apr 10, 2018

fixes #370

This fixes the problem where a class with an extends statement gets an
empty line between the declaration and the opening brace.

This fixes the problem where a class with an extends statement gets an
empty line between the declaration and the opening brace.
@alexander-akait alexander-akait merged commit 59b6248 into prettier:master Apr 10, 2018
@mgrip
Copy link
Copy Markdown
Contributor

mgrip commented Apr 10, 2018

thanks @winged!

loilo pushed a commit that referenced this pull request Apr 5, 2019
Bumps [rollup-plugin-commonjs](https://github.com/rollup/rollup-plugin-commonjs) from 9.3.1 to 9.3.4.
<details>
<summary>Changelog</summary>

*Sourced from [rollup-plugin-commonjs's changelog](https://github.com/rollup/rollup-plugin-commonjs/blob/master/CHANGELOG.md).*

> ## 9.3.4
> *2019-04-04*
> * Make "extensions" optional ([#384](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/384))
> * Use same typing for include and exclude properties ([#385](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/385))
> 
> ## 9.3.3
> *2019-04-04*
> * Remove colon from module prefixes ([#371](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/371))
> 
> ## 9.3.2
> *2019-04-04*
> * Use shared extractAssignedNames, fix destructuring issue ([#303](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/303))
</details>
<details>
<summary>Commits</summary>

- [`851ed8e`](rollup/rollup-plugin-commonjs@851ed8e) 9.3.4
- [`2c447af`](rollup/rollup-plugin-commonjs@2c447af) Update changelog
- [`5cb3b2d`](rollup/rollup-plugin-commonjs@5cb3b2d) set same typing to include and exclude properties ([#385](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/385))
- [`456a223`](rollup/rollup-plugin-commonjs@456a223) make "extensions" optional ([#384](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/384))
- [`3921f28`](rollup/rollup-plugin-commonjs@3921f28) 9.3.3
- [`28421a0`](rollup/rollup-plugin-commonjs@28421a0) Update changelog
- [`e63e57f`](rollup/rollup-plugin-commonjs@e63e57f) fix: remove colon from module prefixes ([#371](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/371))
- [`a34ebbc`](rollup/rollup-plugin-commonjs@a34ebbc) 9.3.2
- [`50696f3`](rollup/rollup-plugin-commonjs@50696f3) Update changelog
- [`34270d4`](rollup/rollup-plugin-commonjs@34270d4) Use extractAssignedNames from rollup-pluginutils. Resolves [#303](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/303) ([#383](https://github-redirect.dependabot.com/rollup/rollup-plugin-commonjs/issues/383))
- See full diff in [compare view](rollup/rollup-plugin-commonjs@v9.3.1...v9.3.4)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=rollup-plugin-commonjs&package-manager=npm_and_yarn&previous-version=9.3.1&new-version=9.3.4)](https://dependabot.com/compatibility-score.html?dependency-name=rollup-plugin-commonjs&package-manager=npm_and_yarn&previous-version=9.3.1&new-version=9.3.4)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newlines before opening braces in class definition

4 participants