Conditional types in generic constraints look confusing

[thorn0]

Prettier 2.2.1
Playground link

Input:

const isNodeOrTokenOfTypeWithConditions = <
  NodeOrToken extends TSESTree.Node | TSESTree.Token,
  NodeOrTokenType extends (NodeOrToken extends TSESTree.Node ? AST_NODE_TYPES : AST_TOKEN_TYPES),
  Conditions extends Partial<NodeOrToken & { type: NodeOrTokenType }>
>(
  nodeOrTokenType: NodeOrTokenType,
  conditions: Conditions
) => (nodeOrToken: NodeOrToken) => true;

Output:

const isNodeOrTokenOfTypeWithConditions = <
  NodeOrToken extends TSESTree.Node | TSESTree.Token,
  NodeOrTokenType extends NodeOrToken extends TSESTree.Node
    ? AST_NODE_TYPES
    : AST_TOKEN_TYPES,
  Conditions extends Partial<NodeOrToken & { type: NodeOrTokenType }>
>(
  nodeOrTokenType: NodeOrTokenType,
  conditions: Conditions
) => (nodeOrToken: NodeOrToken) => true;

Expected behavior:
At least keep the parentheses around NodeOrToken extends TSESTree.Node ? AST_NODE_TYPES : AST_TOKEN_TYPES

Originally posted by @MichaelDeBoey in #7940 (comment)

[MichaelDeBoey]

Wasn't sure if I needed to create a new issue or add it to #7940, so I went with the safe route and just added it there.

Thanks for creating a new issue for me @thorn0! 👊

[fisker]

Marking this good first issue, it should be easy to fix.

1. Add a test case (with less noice)

   const isNodeOrTokenOfTypeWithConditions = <
     NodeOrTokenType extends (NodeOrToken extends TSESTree.Node ? AST_NODE_TYPES : AST_TOKEN_TYPES),
   >() => true;
   

2. Add a logic somewhere to this file https://github.com/prettier/prettier/blob/main/src/language-js/parentheses/needs-parentheses.js

3. Make sure it works for flow syntax too

[fisker]

@kovsu if you are interested