New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print inexact #5304

Merged
merged 5 commits into from Oct 26, 2018

Conversation

Projects
None yet
6 participants
@jbrown215
Contributor

jbrown215 commented Oct 25, 2018

Adds pretty printing for the new inexact object type flow syntax as of 0.84.0. Depends on #5303

jbrown215 added some commits Oct 25, 2018

@lydell

lydell approved these changes Oct 26, 2018

🎉

Show resolved Hide resolved tests/es6modules/__snapshots__/jsfmt.spec.js.snap Outdated

@lydell lydell added this to the 1.15 milestone Oct 26, 2018

//@flow
type T = {
a: number,
...,

This comment has been minimized.

@j-f1

j-f1 Oct 26, 2018

Member

Should this have a trailing comma?

This comment has been minimized.

@ikatyang

ikatyang Oct 26, 2018

Member

I think we should remove the trailing comma here to be consistent with the rest parameters.

@j-f1

⬆️

@existentialism

LGTM besides trailing comma!

@lipis

lipis approved these changes Oct 26, 2018

@jbrown215

This comment has been minimized.

Contributor

jbrown215 commented Oct 26, 2018

Thanks for the quick reviews!

@j-f1

j-f1 approved these changes Oct 26, 2018

@lipis

lipis approved these changes Oct 26, 2018

+125 −989

@j-f1

This comment has been minimized.

Member

j-f1 commented Oct 26, 2018

Looks like the lock file got changed. Are you on the latest Yarn @jbrown215?

@lipis

Upgrade to the latest Yarn and update the yarn.lock

@jbrown215

This comment has been minimized.

Contributor

jbrown215 commented Oct 26, 2018

That was from the change this depended on-- rebased onto master. #5303

@lipis

lipis approved these changes Oct 26, 2018

Waiting for the robots now :)

@lipis lipis merged commit b861448 into prettier:master Oct 26, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.4% (+<.01%) compared to 5d47e02
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

ikatyang added a commit to ikatyang/prettier that referenced this pull request Oct 27, 2018

@existentialism existentialism referenced this pull request Nov 6, 2018

Merged

Bump @babel/parser #5356

2 of 2 tasks complete

ikatyang added a commit that referenced this pull request Nov 7, 2018

Bump @babel/parser (#5356)
Follows #5304 with flow inexact support in @babel/parser!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment