Pretty print inexact#5304
Merged
lipis merged 5 commits intoprettier:masterfrom Oct 26, 2018
jbrown215:pretty_print_inexact
Merged
Pretty print inexact#5304lipis merged 5 commits intoprettier:masterfrom jbrown215:pretty_print_inexact
lipis merged 5 commits intoprettier:masterfrom
jbrown215:pretty_print_inexact
Conversation
j-f1
reviewed
Oct 26, 2018
| //@flow | ||
| type T = { | ||
| a: number, | ||
| ..., |
Member
There was a problem hiding this comment.
Should this have a trailing comma?
Member
There was a problem hiding this comment.
I think we should remove the trailing comma here to be consistent with the rest parameters.
existentialism
approved these changes
Oct 26, 2018
Collaborator
existentialism
left a comment
existentialism
left a comment
There was a problem hiding this comment.
LGTM besides trailing comma!
lipis
approved these changes
Oct 26, 2018
Contributor
Author
|
Thanks for the quick reviews! |
j-f1
approved these changes
Oct 26, 2018
Member
|
Looks like the lock file got changed. Are you on the latest Yarn @jbrown215? |
lipis
requested changes
Oct 26, 2018
Member
lipis
left a comment
lipis
left a comment
There was a problem hiding this comment.
Upgrade to the latest Yarn and update the yarn.lock
Contributor
Author
|
That was from the change this depended on-- rebased onto master. #5303 |
ikatyang
added a commit
to ikatyang/prettier
that referenced
this pull request
Oct 27, 2018
ikatyang
pushed a commit
that referenced
this pull request
Nov 7, 2018
Follows #5304 with flow inexact support in @babel/parser!
lock
bot
added
the
locked-due-to-inactivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds pretty printing for the new inexact object type flow syntax as of 0.84.0. Depends on #5303