Merged
Conversation
Merged
kamilmielnik
approved these changes
Nov 21, 2019
e1himself
reviewed
Nov 21, 2019
kudlajz
approved these changes
Nov 21, 2019
Contributor
kudlajz
left a comment
kudlajz
left a comment
There was a problem hiding this comment.
Kamil already covered everything 👍
Using CoverageSdk to avoid naming collision with Coverage type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/prezly/story/10308/extract-sdk-functionality
There's a ton of changes because of the copied types. These files are exactly the same as in the backend app. The only change is the
Entitytype, which is generic and accepts optionalidtype, while still defaulting tonumber(to match the original).