Merged
Conversation
markogresak
commented
Nov 21, 2019
| }, | ||
| }; | ||
|
|
||
| function successJsonResponse(body, status = 200) { |
Contributor
Author
There was a problem hiding this comment.
This is copied from Api.test.js. I wasn't sure if it was worth it to extract this into "test utils" file.
Node 8.16 (latest LTS release) is currently the oldest supported LTS version.
kamilmielnik
approved these changes
Nov 22, 2019
Contributor
kamilmielnik
left a comment
kamilmielnik
left a comment
There was a problem hiding this comment.
but I believe we should have some tests.
🤷♂️
I think the code is so simple it does not require tests. But if you already did it...
kudlajz
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No task for this. I've skipped doing any tests in the initial implementation of SDK (#2, #6), but I believe we should have some tests.