Improvements to various components in Windows High Contrast Mode - #1111
Conversation
🦋 Changeset detectedLatest commit: 3e8cd7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility by enhancing the styling of various UI components when viewed in Windows High Contrast Mode, addressing multiple accessibility audit issues and improving the user experience for users with visual impairments.
Key changes include:
- Enhanced focus styles for form controls (TextInput, Textarea, Select, Checkbox, Radio) using proper outline styling
- Improved visibility and contrast for interactive elements like VideoPlayer controls, Pagination items, and ActionMenu items
- Updated selected/active state styling for FAQGroup tabs and Pagination current page indicators
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/forms/Textarea/Textarea.module.css | Added high contrast focus styling with outline |
| packages/react/src/forms/TextInput/TextInput.module.css | Added high contrast focus styling with outline |
| packages/react/src/forms/Select/Select.module.css | Added high contrast focus styling with outline |
| packages/react/src/forms/Radio/Radio.module.css | Added high contrast focus and checked state styling |
| packages/react/src/forms/Checkbox/Checkbox.module.css | Added high contrast focus and checked state styling |
| packages/react/src/VideoPlayer/VideoPlayer.module.css | Enhanced visibility of all controls, text, and progress elements |
| packages/react/src/Pagination/Pagination.module.css | Improved current page item styling with thicker border |
| packages/react/src/FAQ/FAQGroup.module.css | Enhanced selected tab styling with thicker border and proper colors |
| packages/react/src/ActionMenu/ActionMenu.module.css | Added high contrast focus styling for menu items |
| .changeset/chilly-yaks-unite.md | Added changelog entry documenting the improvements |

Summary
Improvements to a variety of components when viewed in Windows High Contrast Mode.
There are likely further improvements that could be made across the board and with some more thorough style tweaks we could improve our support for High Contrast Mode across PB, but this PR sets a good baseline and addresses some low-hanging fruit.
List of notable changes
FAQGroup: Improved selected styles for selected tab.Pagination: Improved selected styles for current page item.VideoPlayer: Made all controls and text visible and legible.Checkbox: Improved focus and checked styles.Radio: Improved focus and checked styles.TextInput: Improved focus styles.Textarea: Improved focus styles.ActionMenu: Improved focus styles.What should reviewers focus on?
Steps to test
Supporting resources (related issues, external links, etc)
SWP
Tetralogical accessibility audit
HCL accessibility audit
Contributor checklist
update snapshotslabel to the PR)Reviewer checklist
Videos
ActionMenu
whcm-actionmenu.mp4
FAQGroup
whcm-faqgroup.mp4
VideoPlayer
whcm-desert-videoplayer.mp4
whcm-night-sky-videoplayer.mp4
Pagination
whcm-pagination.mp4
Form
whcm-desert-form.mp4
whcm-night-sky-form.mp4