Skip to content

Security and dependency updates - #291

Merged
rezrah merged 8 commits into
mainfrom
rezrah/update-dependencies-may-23
May 30, 2023
Merged

Security and dependency updates#291
rezrah merged 8 commits into
mainfrom
rezrah/update-dependencies-may-23

Conversation

@rezrah

@rezrah rezrah commented May 26, 2023

Copy link
Copy Markdown
Collaborator

Summary

Part of https://github.com/github/primer/issues/2297

Updates all monorepo depenencies to their latest patch/minor versions and fixes various critical security vulnerabilities, as reported by Dependabot. This should close most - if not all - open Dependabot pull requests.

This is step one of a wider effort to bring the repo up-to-date and reduce the number of security alerts.

List of notable changes:

  • Before: 75 outdated dependencies

  • After: 45 outdated dependencies (all major)

  • Typescript has been upgraded from 4.6 to 4.9, which includes stricter typing around ReactElements.

  • Fixes a11y violation around tabIndex on SubdomainNavBar

What should reviewers focus on?

Steps to test:

  1. Open the preview deployment links here
  2. Navigate between all (or most) stories and documentation pages
  3. Verify that components appear the way they should

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After
Screenshot 2023-05-25 at 18 38 30 Screenshot 2023-05-26 at 09 24 06

@changeset-bot

changeset-bot Bot commented May 26, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a366661

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@primer/brand-primitives Patch
@primer/react-brand Patch
@primer/brand-e2e Patch
@primer/brand-fonts Patch
@primer/brand-config Patch
@primer/brand-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

🟢 No design token changes found

@rezrah
rezrah temporarily deployed to github-pages May 26, 2023 08:47 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@rezrah
rezrah temporarily deployed to github-pages May 26, 2023 10:43 — with GitHub Actions Inactive
@rezrah
rezrah temporarily deployed to github-pages May 26, 2023 11:22 — with GitHub Actions Inactive
@rezrah
rezrah temporarily deployed to github-pages May 26, 2023 11:44 — with GitHub Actions Inactive

@josepmartins josepmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rezrah
rezrah merged commit 6761ce7 into main May 30, 2023
@rezrah
rezrah deleted the rezrah/update-dependencies-may-23 branch May 30, 2023 12:26
@primer-css primer-css mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants