Adjust spacing in river breakout - #883
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 37ceba2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🔍 Design token changes foundView CSS variable changes+ --brand-River-spacing-innerY: var(--base-size-24);+ --brand-River-spacing-innerY: var(--base-size-24);+ --brand-River-spacing-innerY: var(--base-size-32); |
rezrah
commented
Jan 8, 2025
| "value": "var(--base-size-24)" | ||
| }, | ||
| "1280px": { | ||
| "value": "var(--base-size-32)" |
Collaborator
Author
There was a problem hiding this comment.
@danielguillan @jesussandreas For breakout vertical spacing, i only have a reference point for desktop. Left mobile and tablets at 24px as before. Let me know if you feel it should also change.
Contributor
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
danielguillan
approved these changes
Jan 13, 2025
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #873
Part of https://github.com/github/primer/issues/4601
🔗 Storybook preview
List of notable changes:
What should reviewers focus on?
Steps to test:
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots: