-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add namespaced styles to primers spacing #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5d267fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on behalf of engineer-reviewers. Will wait for @lukasoppermann to approve for design
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
| } | ||
|
|
||
| .m-auto { margin: auto !important; } | ||
| .m-auto { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adierkens We probably want to namespace auto as well because of the additional !important
What are you trying to accomplish?
Prefix all
m-andp-util css with a new namespace to enable transitions to tailwind compatible sizingCan these changes ship as is?