Remove default color styles for data-color-mode#3059
Merged
Conversation
Removed default color mode styles for data-color-mode.
🦋 Changeset detectedLatest commit: 1800593 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Updated the version of '@primer/css' from patch to minor and removed default color styles for data-color-mode.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes the default foreground/background styling applied globally to elements with the data-color-mode attribute to prevent unintended styling bleed.
Changes:
- Deleted the
[data-color-mode]rule that set defaultcolorandbackground-color. - Added a changeset to publish the behavioral change in
@primer/css.
Show a summary per file
| File | Description |
|---|---|
| src/base/native-colors.scss | Removes global default fg/bg styling from [data-color-mode]. |
| .changeset/small-tigers-tell.md | Records the release note and version bump for the styling change. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
liuliu-dev
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://github.com/github/primer/issues/6568
Removed default color mode styles for data-color-mode.
What are you trying to accomplish?
This removes the background and color properties for all
data-color-modeattributes. To fix a bug where it's styling areas that are not meant to have these:I believe this was originally added to try and support "nested themes" however this is an artifact from a different time in our engineering. We no longer support nested themes in this way.
What should reviewers focus on?
Can these changes ship as is?