Have primer components extend props for their native elements. #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Cole Bemis <colebemis@github.com>
Co-Authored-By: Cole Bemis <colebemis@github.com>
Co-Authored-By: Cole Bemis <colebemis@github.com>
Co-Authored-By: Cole Bemis <colebemis@github.com>
Co-Authored-By: Cole Bemis <colebemis@github.com>
Getting started
Co-Authored-By: Cole Bemis <colebemis@github.com>
Change is to as
Core Concepts docs
Release 13.4.0
Fixing some Tab/UnderlineNav Link types.
CommonProps should extend interfaces from StyledSystem.
Release Tracking PR 13.5.0
|
This pull request is automatically deployed with Now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the different Props interfaces for primer/components and anywhere we spread the props onto a native element (div, span, a, etc.) or a different component (Box, Button, etc.) I had the props for that component extend the underlying component's props.
This makes it so that the TypeScript definitions more accurately reflect what the JavaScript is doing.
Closes # 540
Merge checklist
index.d.ts) if necessary