Skip to content

Conversation

@langermank
Copy link
Contributor

Closes https://github.com/github/primer/issues/5970

Some CSS got lost in this sx removal PR. We didn't have any VRT tests to catch it so I added some.

@langermank langermank requested a review from a team as a code owner October 9, 2025 20:30
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: cf09077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Patch
@primer/styled-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores missing CSS properties for the KeybindingHint component that were accidentally removed in a previous sx removal refactoring. The missing styles affected the visual appearance of keybinding hint components, including border radius, font size, padding, and line height.

  • Adds back 4 missing CSS properties to the Chord component styling
  • Introduces comprehensive Visual Regression Testing (VRT) and Accessibility Verification Testing (AVT) coverage to prevent similar regressions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/KeybindingHint/components/Chord.module.css Restores missing CSS properties for border-radius, font-size, padding, and line-height
e2e/components/KeybindingHint.test.ts Adds comprehensive VRT and AVT test coverage across all KeybindingHint story variants and themes

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-6972 October 9, 2025 20:34 Abandoned
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 9, 2025
@primer primer bot requested a review from a team as a code owner October 9, 2025 20:49
@primer primer bot requested a review from mperrotti October 9, 2025 20:49
@francinelucca francinelucca added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Oct 9, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4232

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 9, 2025
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 9, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6972 October 9, 2025 20:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6972 October 9, 2025 21:07 Inactive
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 9, 2025
@langermank langermank added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit 3492037 Oct 9, 2025
40 of 41 checks passed
@langermank langermank deleted the fix-keybinding-hint branch October 9, 2025 21:31
@primer primer bot mentioned this pull request Oct 9, 2025
francinelucca added a commit that referenced this pull request Oct 9, 2025
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants