Skip to content

Conversation

@francinelucca
Copy link
Member

v38.0.0-rc.5 introduced some visual regressions to KeyBindingHint this pulls the fix into a new patch release,.

Changelog

New

  • Pull in v38.0.0-rc.5 + new PR fix
  • Update versions to @primer/styled-react@v1.0.0-rc.7, @primer/react@38.0.0-rc.6

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@francinelucca francinelucca requested a review from a team as a code owner October 9, 2025 22:10
Copilot AI review requested due to automatic review settings October 9, 2025 22:10
@francinelucca francinelucca requested a review from a team as a code owner October 9, 2025 22:10
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: be27326

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a patch release to address visual regressions in KeyBindingHint component that were introduced in v38.0.0-rc.5. The PR updates both packages to new release candidate versions and includes the fix for the KeyBindingHint styling issues.

  • Adds missing CSS styling properties for KeyBindingHint component
  • Updates package versions to @primer/react@38.0.0-rc.6 and @primer/styled-react@1.0.0-rc.7
  • Refactors styled-react components to use styled-components wrapper instead of Box

Reviewed Changes

Copilot reviewed 15 out of 88 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/KeybindingHint/components/Chord.module.css Adds missing border-radius, font-size, padding, and line-height styles
packages/styled-react/src/components/Token.tsx Refactors to use styled-components wrapper with forwardRef pattern
packages/styled-react/src/components/Spinner.tsx Simplifies implementation using styled-components wrapper
packages/styled-react/src/components/Label.tsx Updates to use styled-components wrapper pattern
e2e/components/KeybindingHint.test.ts Adds comprehensive E2E tests for KeybindingHint component
packages/react/package.json Updates version to 38.0.0-rc.6
packages/styled-react/package.json Updates version to 1.0.0-rc.7 and dependencies
examples/*/package.json Updates dependency versions across example projects
CHANGELOG.md files Documents changes for both packages
.changeset files Adds changeset entries for the patch releases

@francinelucca
Copy link
Member Author

published v38.0.0-rc.6, v1.0.0-rc.7, closing

@jonrohan jonrohan deleted the patch/v38.0.0-rc.6 branch October 30, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants