-
Notifications
You must be signed in to change notification settings - Fork 645
Major Release Tracking Issue #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropdown Refactor 🧹
Keep theme out of Jest snapshots
BinaryMuse
approved these changes
Apr 2, 2020
Contributor
BinaryMuse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excitebike.gif
Follow up items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tracking issue for the next major release (currently planned to go out as 17.0.0)
🔧 Breaking changes
Dialogcomponents no longer render with a header by default. Extract Dialog header into separate component #736 @BinaryMuseMigration strategy: change any
Dialogcomponent with atitleprop set as follows:to
Headingnow renders anh2by default instead of anh1Heading update (new default level and updated docs) #716 @taylorcjohnsonMigration strategy: change any use of the
Headingcomponent without anasprop:to
Dropdown elements no longer provide a Dropdown button by default - this allows users to pass in any type of
summaryelement so the component can work well for different types of dropdowns Dropdown and Details Refactor 🧹 #729.Migration strategy: change any
Dropdowncomponent with atitleprop set as follows:to
We've also added the ability to manage the
openstate and provide custom handles foronToggleandonOutsideClickto theDetailscomponent andDropdowncomponent for more flexibility and reusability 🎉 🙌✨ New Components
🐛 Bug Fixes