Extract Dialog header into separate component #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/664ijgvj2 |
colebemis
approved these changes
Apr 1, 2020
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Nice, @BinaryMuse! I like this API a lot better ❤️
emplums
reviewed
Apr 1, 2020
emplums
suggested changes
Apr 1, 2020
|
|
||
| const Dialog = ({title, children, ...props}) => { | ||
| function DialogHeader({theme, children, ...rest}) { | ||
| if (React.Children.toArray(children).every(ch => typeof ch === 'string')) { |
Closed
acknosyn
added a commit
to acknosyn/components
that referenced
this pull request
Apr 14, 2020
…der-extraction" Extract Dialog header into separate component - (Edit) add commit be6ed3
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the
Dialogheader into a separate component, thus making it optional and more customizable. It also shifts default props around so that default styling is not affected, but users can still customize the background and flex properties of the header.Since the original incarnation had specific styling for string titles, I've extracted the header into two components:JK this is fixed.Dialog.Headerfor fully custom headers, andDialog.HeaderTextfor headers with only text that should match the original styles. I'm not a huge fan of this solution and am open to other ideas.Finally, the close button has been placed as the first child inside
StyledDialogso that it retains initial focus when the dialog is opened.Closes #730
Merge checklist
index.d.ts) if necessaryBreaking changes
This PR introduces a breaking change.
Migration strategy
Change any
Dialogcomponent with atitleprop set as follows:to