Skip to content

Fix DropdownProps type intersections #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Fix DropdownProps type intersections #725

merged 1 commit into from
Mar 23, 2020

Conversation

@clayplumridge
Copy link
Contributor

@clayplumridge clayplumridge commented Mar 23, 2020

Fixes issues with DropdownProps

Screenshots

No visual changes

Merge checklist

There are no functional (read: JS) changes.

  • Added or updated TypeScript definitions (index.d.ts) if necessary
  • Added/updated tests (unnecessary)
  • Added/updated documentation (unnecessary)
  • Tested in Chrome (unnecessary)
  • Tested in Firefox (unnecessary)
  • Tested in Safari (unnecessary)
  • Tested in Edge (unnecessary)

@vercel
Copy link

vercel bot commented Mar 23, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-components/k1t8nmkap
✅ Preview: https://primer-components-git-fork-clayplumridge-patch-1.primer.now.sh

@vercel vercel bot temporarily deployed to Preview March 23, 2020 17:01 Inactive
@emplums emplums changed the base branch from master to minor March 23, 2020 19:54
emplums
emplums approved these changes Mar 23, 2020
View reviewed changes
Copy link

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌

@emplums emplums merged commit 38b9cf4 into primer:minor Mar 23, 2020
@emplums emplums mentioned this pull request Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emplums emplums emplums approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clayplumridge @emplums