Skip to content

Add flex-wrap to buttons in All Directions story#7647

Merged
llastflowers merged 3 commits intomainfrom
llastflowers/14982/tooltip-all-directions-responsive-fix
Mar 11, 2026
Merged

Add flex-wrap to buttons in All Directions story#7647
llastflowers merged 3 commits intomainfrom
llastflowers/14982/tooltip-all-directions-responsive-fix

Conversation

@llastflowers
Copy link
Contributor

Addresses https://github.com/github/accessibility-audits/issues/14982

Changelog

New

Added flex-wrap to buttons in All Directions Tooltip story to eliminate the need for horizontal scrolling on very small viewports (320x256)

Before:
Tooltip story buttons before changes

After:
Tooltip story buttons after changesTooltip story buttons after changes scrolled down

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None (Storybook only)

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings March 9, 2026 17:51
@llastflowers llastflowers requested a review from a team as a code owner March 9, 2026 17:51
@llastflowers llastflowers requested a review from hectahertz March 9, 2026 17:51
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2026

⚠️ No Changeset found

Latest commit: ea475f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the accessibility and usability of the TooltipV2 Storybook feature stories at small viewport sizes (e.g. 320×256) by allowing the button rows to wrap instead of requiring horizontal scrolling.

Changes:

  • Added flex-wrap: wrap to .AllDirectionsRow and .ActionMenuRow CSS classes so buttons reflow to multiple rows on narrow viewports.

@llastflowers llastflowers added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Mar 9, 2026
@github-actions github-actions bot temporarily deployed to storybook-preview-7647 March 9, 2026 18:02 Inactive
@llastflowers llastflowers enabled auto-merge March 11, 2026 16:15
Copy link
Contributor

@liuliu-dev liuliu-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue has a “Note” calling out the same scrolling on other stories, should we fix them too? 👀

Copy link
Contributor

@liuliu-dev liuliu-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing! ❤️

@llastflowers llastflowers added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit dce3126 Mar 11, 2026
53 checks passed
@llastflowers llastflowers deleted the llastflowers/14982/tooltip-all-directions-responsive-fix branch March 11, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants