Skip to content

Add flex-wrap to buttons in All Directions story #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llastflowers merged 3 commits into from
Mar 11, 2026
Merged

Add flex-wrap to buttons in All Directions story #7647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1e51a
add flex-wrap to buttons in All Directions story
llastflowers Mar 9, 2026
3a4dea2
same fix in inactive buttons story
llastflowers Mar 11, 2026
ea475f9
add media query for small viewports in data table with overflow story
llastflowers Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/src/Button/Button.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {announce} from '@primer/live-region-element'
import {Tooltip} from '../TooltipV2/Tooltip'
import {KeybindingHint} from '../KeybindingHint'
import VisuallyHidden from '../_VisuallyHidden'

export default {
title: 'Components/Button/Features',
}
Expand Down Expand Up @@ -129,7 +130,7 @@ export const Disabled = () => (
)

export const Inactive = () => (
<div style={{display: 'flex', flexDirection: 'row', gap: '1rem'}}>
<div style={{display: 'flex', flexWrap: 'wrap', flexDirection: 'row', gap: '1rem'}}>
<VisuallyHidden id="inactive-state">Inactive</VisuallyHidden>
<Button inactive aria-describedby="inactive-state">
Default
Expand Down
11 changes: 11 additions & 0 deletions packages/react/src/DataTable/DataTable.features.stories.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,14 @@
align-items: center;
gap: var(--base-size-4);
}

.WithOverflowWrapper {
/* stylelint-disable-next-line primer/responsive-widths */
width: 500px;
}

@media (max-width: 500px) {
.WithOverflowWrapper {
width: 100%;
}
}
6 changes: 1 addition & 5 deletions packages/react/src/DataTable/DataTable.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,11 +1151,7 @@ export const WithNoContent = () => {
}

export const WithOverflow = () => (
<div
style={{
width: 500,
}}
>
<div className={classes.WithOverflowWrapper}>
<Table.Container>
<Table.Title as="h2" id="repositories">
Repositories
Expand Down
2 changes: 2 additions & 0 deletions packages/react/src/TooltipV2/Tooltip.features.stories.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@
.AllDirectionsRow {
padding: var(--base-size-32);
display: flex;
flex-wrap: wrap;
gap: var(--base-size-8);
}

.ActionMenuRow {
display: flex;
flex-wrap: wrap;
padding: var(--base-size-32);
gap: var(--base-size-8);
}
Expand Down
Loading